Security hardening: MCP gateway fixes, notification bypass, DLP scanning, code consolidation #35
Merged
chen-zichen merged 2 commits intomainfrom Feb 27, 2026
Merged
Security hardening: MCP gateway fixes, notification bypass, DLP scanning, code consolidation #35chen-zichen merged 2 commits intomainfrom
chen-zichen merged 2 commits intomainfrom
Conversation
- JSON-RPC batch bypass: extract processMessage() from PipeInspect loop, add processBatch() that inspects each element individually - Notification params DLP: scan Params field on notifications (method+no id) to catch secrets embedded by malicious servers - Server-initiated MCP methods: add sampling/createMessage and elicitation/create to security-relevant method conversion
…ax.Quote - Fix notification bypass: notifications with security-relevant methods (tools/call, fs/read_text_file, etc.) now go through converter + rule engine, not just DLP scanning - Extract scanDLP() and forwardLine() helpers in pipe.go - Replace hand-rolled shellQuote with mvdan.cc/sh syntax.Quote - Add shared testutil.NewEngine() test helper - Remove redundant tests that duplicate coverage from jsonrpc layer
chen-zichen
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
now go through the converter + rule engine, not just DLP scanning
in both result and error fields
test coverage across proxy layers
Test plan
go build ./...passesgo test -race ./...passesSecurity checklist