Fix race condition causing double MMR revert on match cancellation#106
Open
ershisan99 wants to merge 1 commit intomainfrom
Open
Fix race condition causing double MMR revert on match cancellation#106ershisan99 wants to merge 1 commit intomainfrom
ershisan99 wants to merge 1 commit intomainfrom
Conversation
The cancel path lacked the `processingMatchEnds` guard that the win path already used, allowing concurrent cancel calls to double-revert MMR. Also added early return in `endMatch` when a cancelled match is already closed, and added returns after helper/log-channel cancel to prevent fall-through into the vote path. https://claude.ai/code/session_01FqCy7mK1fGVg3cR9Fcxpa2
Collaborator
Author
|
Haven't checked the code yet, just had Claude do it from my phone, will double check tmrw |
robotzurg
approved these changes
Apr 10, 2026
Collaborator
robotzurg
left a comment
robotzurg
left a comment
There was a problem hiding this comment.
Looks good to me personally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cancel path lacked the
processingMatchEndsguard that the winpath already used, allowing concurrent cancel calls to double-revert
MMR. Also added early return in
endMatchwhen a cancelled match isalready closed, and added returns after helper/log-channel cancel to
prevent fall-through into the vote path.
https://claude.ai/code/session_01FqCy7mK1fGVg3cR9Fcxpa2