Open
Conversation
awadell1
requested changes
Jun 8, 2023
Member
awadell1
left a comment
awadell1
left a comment
There was a problem hiding this comment.
If lammps-allegro doesn't work it needs to be split off of this PR or get deleted
eegmark runs everything in the benchmarks, so everything needs to work, or not be there
| @@ -0,0 +1,32 @@ | |||
| import os | |||
Member
There was a problem hiding this comment.
This doesn't seem to print a score, is 1/wall time sufficient?
Author
There was a problem hiding this comment.
it writes a yaml file with different performance metrics. 1/wall time is sufficient, but there is also a timesteps/s that is a more standard metric that is to be maximized
|
Wait. If @emilannevelink is doing this then why am I doing it as well? @awadell1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also added the work in progress lammps-allegro, but that isn't ready yet.