Pr snip not work

[Shane-XB-Qian]

closes #44

[Beaglefoot]

Looks good. Could you please remove 3 lines mentioned in other comment? And I'll merge.

[Shane-XB-Qian]

remove 3 lines mentioned in other comment

what's that? i did not get you.. 😄

[Shane-XB-Qian]

you meant not to change snip dict's title which in snippets.json, those 3 lines?

[Beaglefoot]

These 3 lines are unnecessary and added on CompletionResolve event with enrichWithSnippetDetails function.

[Shane-XB-Qian]

actually have to, otherwise those are not snip items.
those are working for auto completion, vs compared to completionResolve looks those for manual omni completion.

[Beaglefoot]

remove 3 lines mentioned in other comment

what's that? i did not get you.. smile

Totaly forgot to submit review ;)

[Shane-XB-Qian]

and this pr is just trying to solve auto completion for snip from snippets.json
but general func/var etc items looks you had to make them to be generated automatically also.
// and/or as #45 said, those/you generated items format seems cannot be recognized actually.
// and seems you did not impl trigger char feature.

[Shane-XB-Qian]

and did not impl textDocument/signatureHelp feature too. 😄

[Shane-XB-Qian]

update: the auto-compl cannot work perhaps just #45 the generated fmt was not recognized.
// just a guess, no way/yet to verify it.

[Shane-XB-Qian]

@Beaglefoot
perhaps either merge this,
or give up snip from lsp server side (rollback that previous snip commit), mostly local may have snip plugin already, that's some kinds of dup.
// anyway, #45 should be a good enhance when you have time to refine.

[Shane-XB-Qian]

please refer bash-lsp/bash-language-server#897 (comment)