Make the loop iterating over multiple parquet files parallel#4952
Open
e-kayrakli wants to merge 2 commits intoBears-R-Us:mainfrom
Open
Make the loop iterating over multiple parquet files parallel#4952e-kayrakli wants to merge 2 commits intoBears-R-Us:mainfrom
e-kayrakli wants to merge 2 commits intoBears-R-Us:mainfrom
Conversation
Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
Contributor
|
This looks like it should be a no-brainer, but when I pulled it and ran tests, the test_poisson_seed_reproducibility test (which does use parquet) failed. |
ajpotts
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #4906, I converted a parallel loop in to a serial one for better debugging, but then forgot to make it parallel again. This was observed as a performance regression in a use case. This PR adds the
forallloop back instead of theforloop. Note that a similar part of code, that's used for col-by-col reads already uses a parallel loop.I spot-checked the correctness.