fix(ci): share adopter Playwright in exact runtime - #335
Merged
Conversation
🗺️ StyleProof report📊 View the side-by-side visual report →Coverage, determinism, or report/diff consistency evidence is incomplete — repair the capture or reflow source; visual approval cannot clear this failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why does this feature exist?
StyleProof 4.7.1 isolated its exact npm runtime to preserve an adopter base lockfile, but that runtime brought a second
@playwright/testinstance. In Fleet’s real cold-base run, the StyleProof runner loaded the isolated instance while the adopter config/spec and CLI loaded Fleet’s locked instance. Playwright rejected the second load, the base capture collapsed, and 223 unchanged surfaces were falsely reported as new.What changed?
@playwright/testresolution to the adopter base worktree’s locked package, making the CLI, config, spec, and StyleProof runner share one module instance.Behavioural Proof (with video and screenshots)
The full browser engine suite also passed:
116 passed.Verification Summary
.agents/project/DEFINITION_OF_DONE.md.npm test;npm run typecheck;npm run lint;npm run format:check;npm run privacy:check;npx playwright install chromium;npm run test:e2e;npm audit --audit-level=high;npm pack --dry-run;git diff --check.Checklist
docs/demo/report.md, or pasted the command/test output that demonstrates the changenpm run demo:reportand committeddocs/demo/— Not applicable: module resolution changes, rendered report output does not.npm run build && npm run typecheck && npm run lint && npm run format:checkpassnpm testpasses (andnpm run test:e2eif the capture/engine path changed).agents/project/DEFINITION_OF_DONE.mdand.agents/skills/pr-inline-screenshot-proof/SKILL.md, or the proof section saysNot applicablewith the technical reason