add the reformulated version of Fiedler_BMCSystBiol2016#258
add the reformulated version of Fiedler_BMCSystBiol2016#258m-philipps merged 19 commits intomasterfrom
Conversation
|
would assume that all of the data is the same – why not just add separate model/parameters/yaml file to the base directory and reuse everything else? |
|
The data is the same, the observable Ids changed (e.g. I could rename the observables and associated parameters but I have a minor preference for keeping the new names to distinguish the interpretation of the observables in the old and reformulated model. |
dilpath
left a comment
There was a problem hiding this comment.
Looks good. Since this is similar to submitting a new problem, you could add the checklist to this PR and indicate what is done/not done (of course, not everything has to be done since this is not the "main" problem -- simply leave those unchecked as a matter of record).
Benchmark-Models/Fiedler_BMCSystBiol2016/measurementData_Fiedler_BMCSystBiol2016.tsv
Show resolved
Hide resolved
Benchmark-Models/Fiedler_BMCSystBiol2016/reformulated/parameters_Fiedler_BMCSystBiol2016.tsv
Show resolved
Hide resolved
Benchmark-Models/Fiedler_BMCSystBiol2016/reformulated/Fiedler_BMCSystBiol2016.yaml
Outdated
Show resolved
Hide resolved
Benchmark-Models/Fiedler_BMCSystBiol2016/reformulated/model_Fiedler_BMCSystBiol2016.xml
Show resolved
Hide resolved
|
I think this is missing, but also fine to uncheck this box instead. |
Fiedler_BMCSystBiol2016model, taken from the same publication, that removes non-identifiabilitiesdatasetIdcolumn for the existingFiedler_BMCSystBiol2016model