Skip to content

Fix docs.rs build for xsd-parser-types when all-features is enabled#278

Merged
Bergmann89 merged 3 commits into
masterfrom
copilot/fix-docs-build-xsd-parser-types
Jun 21, 2026
Merged

Fix docs.rs build for xsd-parser-types when all-features is enabled#278
Bergmann89 merged 3 commits into
masterfrom
copilot/fix-docs-build-xsd-parser-types

Conversation

Copilot AI commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

xsd-parser-types docs were failing on docs.rs because docs.rs builds with all-features, which enabled serde-based derives without enabling serde's derive support. This PR aligns crate feature wiring so the docs build path matches enabled code paths.

  • Root cause

    • #[derive(serde::Serialize, serde::Deserialize)] is conditionally enabled behind the crate’s serde feature.
    • The serde dependency was optional but did not enable serde’s derive feature, so derive macros were unavailable in docs.rs all-features builds.
  • Change

    • Updated xsd-parser-types/Cargo.toml to enable derive support on the optional serde dependency:
      serde = { workspace = true, optional = true, features = ["derive"] }
  • Impact

    • Restores docs.rs compatibility for xsd-parser-types under all-features.
    • Keeps existing feature model intact; only serde macro availability is corrected.

Closes #277

Copilot AI changed the title [WIP] Fix docs.rs build for xsd-parser-types Fix docs.rs build for xsd-parser-types when all-features is enabled Jun 20, 2026
Copilot AI requested a review from Bergmann89 June 20, 2026 23:29
@Bergmann89 Bergmann89 marked this pull request as ready for review June 20, 2026 23:38
@Bergmann89

Copy link
Copy Markdown
Owner

@copilot For some reason the CI pipeline did not start. Run it again.

Copilot AI commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

@copilot For some reason the CI pipeline did not start. Run it again.

I reran CI by pushing commit 6e0c626, which triggered a new Main workflow run (#552). It still ends in action_required with no jobs started, so it appears to require manual approval in Actions before jobs can execute.

Copilot AI requested a review from Bergmann89 June 21, 2026 11:52
@Bergmann89 Bergmann89 merged commit 0b23e7c into master Jun 21, 2026
2 checks passed
@Bergmann89 Bergmann89 deleted the copilot/fix-docs-build-xsd-parser-types branch June 21, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs.rs build failed for xsd-parser-types

2 participants