Fix docs.rs build for xsd-parser-types when all-features is enabled#278
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix docs.rs build for xsd-parser-types
Fix docs.rs build for Jun 20, 2026
xsd-parser-types when all-features is enabled
Bergmann89
approved these changes
Jun 20, 2026
Owner
|
@copilot For some reason the CI pipeline did not start. Run it again. |
Contributor
Author
I reran CI by pushing commit |
Bergmann89
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xsd-parser-typesdocs were failing on docs.rs because docs.rs builds withall-features, which enabled serde-based derives without enablingserde's derive support. This PR aligns crate feature wiring so the docs build path matches enabled code paths.Root cause
#[derive(serde::Serialize, serde::Deserialize)]is conditionally enabled behind the crate’sserdefeature.serdedependency was optional but did not enableserde’sderivefeature, so derive macros were unavailable in docs.rsall-featuresbuilds.Change
xsd-parser-types/Cargo.tomlto enable derive support on the optional serde dependency:Impact
xsd-parser-typesunderall-features.Closes #277