Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new constructor API:
This aims to reduce boilerplate involved in node authoring and integration with
bevy_ecs. With a node's configuration exposed as an associated type, we can remove the need to create intermediateConstructortypes, and we can use this associated type to make concise ECS APIs.As a part of these changes, I've tried to consolidate some types to simplify their APIs. Most notably, I consolidated the
SamplerParamsandSamplerHandletypes. TheRmsParamsin thecustom_nodesexample illustrates why this is useful in a more self-contained way than the sampler.Not all nodes are completely ported to this paradigm. In particular, the input and output stream nodes as well as the CPAL input node present some issues and may need more consideration before merging.