Clap_branch add CLAP node Part 1/2 #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1/2 is clack host integration with custom node
Part 2/2 (later) is being able to modify plugin parameters within custom node.
Changes to firewheel cargo.toml were made just so it would compile. I don't understand changes. I just know it compiles. I just know it says freeverb error with Billy's Cargo.toml.
If you can make changes so it compiles just fine without my changes in Cargo.toml inside Firewheel folder, fine. Just trying to explain myself the best I can. If there are better changes, great.
The other toml file in custom_nodes does require changes and that file is ok with changes.
Summary: TLDR I just did Firewheel folder Cargo.toml changes just so it would compile. I don't know if changes that I made are required. I just know it compiles with my changes. Sorry for not being more diff with the changes. I just wanted to avoid freeverb compile error I got.