-
-
Notifications
You must be signed in to change notification settings - Fork 17
Add Echo/Delay node #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
added back stopping. pause still strange, time changing still can click smoothed filter values
…ixed wrapping issue causing occasional panics. Separated delay line into dsp.
|
OK, I did some additional testing, and it seems that the issue I was running into where all |
|
|
||
| /// Read the least recent sample pushed to this delay line (the sample that | ||
| /// will be replaced with the next [`Self::write_and_advance`]). | ||
| pub fn read_last(&self) -> f64 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of this can use some bikeshedding, idk if these are correct terms
Drafting to track #16 - some things to fix, but I think this is close. Still need to fix issues with pause behavior and time change clicking,
as well as smoothing filter values (done). There also may be some performance improvements to be made, especially with how I am handling interpolating between times.I modeled this after what I presume is happening with Bitwig's delay effect, which allows for both single echos and feedback delays.
Issue criteria:
tap_gain- I found this was redundant with themixandfeedbackfeedback_lpf. I think feedback is more generally understood than tap (and should be more accurate in this case as well).feedback_hpffor above reasonenabled- Not needed withmixsettingAdditional features
Tradeoffs