reimplement as you type search with 500ms debounce#15
Open
nlsg wants to merge 1 commit intoBioHapHazard:mainfrom
Open
reimplement as you type search with 500ms debounce#15nlsg wants to merge 1 commit intoBioHapHazard:mainfrom
nlsg wants to merge 1 commit intoBioHapHazard:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all: I now you rolled the feature back, so I'm fine with you not merging
Anyway, I could not reproduce rate limit issues.
I think this is so much of a better user experience, - I now you think the same xD
I thought about implementing an algorithm to detect how fast of a typer the user is and adjust the debounce dynamically..
I guess 500ms is still okey for slow users
maybe It would be nice to implement a setting for this..