Fix: Removes length restriction on writeXStringSet, writeQualityScaledXStringSet#122
Open
ahl27 wants to merge 3 commits intoBioconductor:develfrom
Open
Fix: Removes length restriction on writeXStringSet, writeQualityScaledXStringSet#122ahl27 wants to merge 3 commits intoBioconductor:develfrom
writeXStringSet, writeQualityScaledXStringSet#122ahl27 wants to merge 3 commits intoBioconductor:develfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeXStringSetandwriteQualityScaledXStringSetpreviously restricted inputs based on the width of sequences due to limitations in the internal I/O buffer. Now arbitrarily long sequences can be written, resulting in support forwidth > 200003forXStringSetobjects and also support for writingQualityScaledXStringSetobjects with sequences longer than 200kbp.More specific changes:
writeXStringSetnow supports any integer value forwidthwriteXStringSetcalled with zero or negative values forwidthwill now using unbounded width (i.e., each sequence written on a single line)writeQualityScaledXStringSetnow functions for sequences of arbitrary length, fixing Issue 177 (Error writing long reads with writeQualityScaledXStringSet #117)SolexaQualityandIlluminaQuality, as well as verifying that the output widths are the correct number of characters.