Open
Conversation
LegoMaster7001
changed the title
Karsten-Larson
previously approved these changes
Jan 16, 2026
Collaborator
Karsten-Larson
left a comment
Karsten-Larson
left a comment
There was a problem hiding this comment.
Minor changes. Can ignore due to time crunch
| #how off the coordinates can be from each other | ||
| distanceError = 0.25 | ||
|
|
||
| class coordinateComparison(Node): |
Collaborator
There was a problem hiding this comment.
Should be CoordinteComparision to follow Python convention
| import cv2 | ||
|
|
||
| #how off the coordinates can be from each other | ||
| distanceError = 0.25 |
Collaborator
There was a problem hiding this comment.
DISTANCE_ERROR since constant
| import cv2 | ||
|
|
||
|
|
||
| class gpsConversion(Node): |
Collaborator
|
Have you added entry points to these nodes? These will be needed |
Collaborator
|
I will do the merge conflict changes when it is time for that. We got rid of the apriltag changes |
Co-authored-by: Karsten Larson <Karsten-Larson@users.noreply.github.com>
Co-authored-by: brandongasser <bgasser12@gmail.com> Co-authored-by: Karsten Larson <karsten.larson.1@gmail.com> Co-authored-by: kaitlyn-nickel <nickelk102703@gmail.com>
Co-authored-by: Brandon Gasser <brandongasser@users.noreply.github.com> Co-authored-by: Gannon Andrews <LegoMaster7001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added comparison to see if the GPS and AprilTags are within a range of each other. It will average out the points if they are close, and will return apriltag if they are too far apart.
added GPS convesion to convert the robot's global position to local field coordinates.