fix(sdk-coin-flrp): signature ordering according to flareJS lib #7968
+607
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (senderIdx === bitgoIndex) { | ||
| // This sigIndex slot is for BitGo (HSM) - empty signature | ||
| emptySignatures.push(utils.createNewSig('')); | ||
| } else if (senderIdx === firstIndex) { |
Contributor
There was a problem hiding this comment.
You can add this condition in if block and rest everything can be else as both ways you are only adding empty signatures.
Comment on lines
+402
to
+405
| if (senderIdx === bitgoIndex) { | ||
| addressMap.set(new Address(sender[bitgoIndex]), slotIdx); | ||
| } else if (senderIdx === firstIndex) { | ||
| addressMap.set(new Address(sender[firstIndex]), slotIdx); |
Contributor
There was a problem hiding this comment.
If bitgoIndex and firstIndex does not require separate handling, it is wise to move them together and simply do -
addressMap.set(new Address(sender[senderIdx]), slotIdx);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WIN-8692