feat: EVM clear signing — EthBlindSigning policy + signed metadata - #61
Merged
Conversation
BitHighlander
force-pushed
the
feature/evm-clear-signing
branch
7 times, most recently
from
March 18, 2026 21:45
c14cfc9 to
3dcadef
Compare
EthBlindSign policy: hard-rejects unknown contract data when disabled. Defaults to enabled (no behavior change for existing users). Signed metadata: host sends EthereumTxMetadata (msg 115) before EthereumSignTx with cryptographically-signed blob. Device verifies secp256k1 signature, validates contract/selector/chainId binding, shows rich OLED confirmation with decoded args. Key derived from BIP-39 mnemonic via SignIdentity(keepkey.com/insight). Backwards compatible — old hosts unchanged, all existing tests pass.
BitHighlander
force-pushed
the
feature/evm-clear-signing
branch
from
March 18, 2026 21:54
3dcadef to
82a56e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EthereumTxMetadata(msg 115) beforeEthereumSignTx. Device verifies secp256k1 signature against embedded pubkeys, validates contract/selector/chainId binding, shows rich OLED confirmation (method name, checksummed contract, decoded args).Files
signed_metadata.c/h— binary parser, sig verifier, OLED display (370 lines)policy.h— append EthBlindSigningethereum.c— metadata check + blind signing gate (+30 lines)fsm_msg_ethereum.h— EthereumTxMetadata handlermessagemap.def— wire new msg typesCMakeLists.txt— add sourceDependencies
Test plan