Add new 'Add Channel' page for Notifications#403
Open
pavel-fokin wants to merge 9 commits intoBithomp:mainfrom
Open
Add new 'Add Channel' page for Notifications#403pavel-fokin wants to merge 9 commits intoBithomp:mainfrom
pavel-fokin wants to merge 9 commits intoBithomp:mainfrom
Conversation
ihomp
approved these changes
Jun 29, 2025
ihomp
requested changes
Jun 29, 2025
Member
ihomp
left a comment
ihomp
left a comment
There was a problem hiding this comment.
Module not found: Can't resolve 'zod'
1 | import { z } from 'zod'
Member
|
I couldn't test I don't see in the packages what do we need it for? How far we are fro PR here? |
added 6 commits
June 30, 2025 15:54
- Add deletePartnerConnection API function - Refactor ChannelCard component into modular structure with separate files - Add ChannelDeleteDialog component for confirmation - Add useDeleteNotificationChannel hook - Create reusable Dialog UI component with styling - Move NOTIFICATION_CHANNEL_TYPES from constants.js to notificationChannels.js - Update imports to use consolidated notificationChannels module
pavel-fokin
force-pushed
the
notifications-add-channel
branch
from
cb0e157 to
93ee5f0
Compare
Merged
Member
|
this is still doesn't work for me to test:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.