Suggestion: Use 'next-themes' for theme switching#430
Open
pavel-fokin wants to merge 1 commit intoBithomp:mainfrom
Open
Suggestion: Use 'next-themes' for theme switching#430pavel-fokin wants to merge 1 commit intoBithomp:mainfrom
pavel-fokin wants to merge 1 commit intoBithomp:mainfrom
Conversation
Member
|
The whole purpose of the script in [_document.js] that the right theme will be used right away before rendering.. so we don't have a "flash" of white or black background etc when refreshing the page, or when there is no cookie yet. it's also good not to wait for mounted=true in many cases. I wouldn't touch it what we have.. just to make sure we don't break all the edge cases we used to test relates to themes. What is the reason for a change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rely on the standard solution rather than a custom script. Not sure if I missed some extra logic in custom script.
Recieptpage.