Open
Conversation
lightyear15
reviewed
Apr 12, 2023
There was a problem hiding this comment.
Besides few changes that improve / fix the build, many of the changes included in this PR are breaking changes that change the behaviour of the APIs of the library.
There might be implications for users.
I'd rather define some sort of macros, like in this short example
| assert(false); | ||
| } | ||
|
|
||
| return ByteVector(); |
There was a problem hiding this comment.
Suggested change
| return ByteVector(); | |
| return {}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.