series of improvements to this library#13
Open
lightyear15 wants to merge 5 commits intoBlockchainCommons:masterfrom
Open
series of improvements to this library#13lightyear15 wants to merge 5 commits intoBlockchainCommons:masterfrom
lightyear15 wants to merge 5 commits intoBlockchainCommons:masterfrom
Conversation
lightyear15
force-pushed
the
misc
branch
7 times, most recently
from
477f3cb to
5970a2f
Compare
also adding a github workflow task that compiles, runs tests and installs the produced artifacts
it practically does not enforce any sort of const-correctness while polluting the code.
even though syntatically correct, it does make little sense on classes that reprensent front-end APIs of this library for different reasons. On one side, as these classes have no virtual methods and no protected member variables, they and their internal machineries are already shielded against weird uses. Secondly, preventing this library's users to use these classes as base class does not put library authors under any further future obligation of not deprecating old code, or changing APIs.
replacing C-style arrays with std::array adding const-qualified autos removing return types replacing typedefs with usings replacing NULL with nullptr
simply more efficient
greenaddress
pushed a commit
to Blockstream/esp32_bc-ur
that referenced
this pull request
May 15, 2024
greenaddress
pushed a commit
to Blockstream/esp32_bc-ur
that referenced
this pull request
May 15, 2024
jgriffiths
pushed a commit
to Blockstream/esp32_bc-ur
that referenced
this pull request
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in short:
finalfrom main classes