Refactor: Files Page #109
Closed
Refactor: Files Page #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itemclick helper_methods: updated the get_file_loc method to return always the filename instead of the full path Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
…file_name Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
gmmcosta15
added
the
Refactor
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| def _setup_scrollbar(self) -> None: | ||
| idx = self.model.index(0, 0) | ||
|
|
||
| rect = self.listWidget.rectForIndex(idx) |
| from lib.utils.icon_button import IconButton | ||
| from lib.utils.list_button import ListCustomButton | ||
| from PyQt6 import QtCore, QtGui, QtWidgets | ||
| from lib.utils.blocks_frame import BlocksCustomFrame |
…g commented lines Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
helper_methods.py: created method
get_file_namethat accepts a string with the filepath and returns only the filenamefilesPage.py: Changed implementation of how the files are showed, from a ´QtWidgets.QListWidgetItem´ to our custom
EntryListModelScreenshots
Future Work
on_delete_fileSlot