-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor SensorPanel: replace QListWidgetItem with EntryListModel
#125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gmmcosta15
wants to merge
10
commits into
dev
Choose a base branch
from
ref/sensor-panel
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WidgetItem to a ListModelView Arq with some bugfixes Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
SensorPanel: replace QListWidgetItem with EntryListModel #124
SensorPanel: replace QListWidgetItem with EntryListModel #124SensorPanel: replace QListWidgetItem with EntryListModel
| # TODO: Implement this | ||
|
|
||
| def getFilesToDelete(self) -> list[str]: ... | ||
| global MainLoggingHandler |
| RF50_DATASHEET_PAGE = ( | ||
| "https://www.blockstec.com/assets/downloads/rf50_datasheet.pdf" | ||
| ) | ||
| RF50_DATASHEET_PAGE = "https://www.blockstec.com/assets/downloads/rf50_datasheet.pdf" |
| self.panel.cp_z_tilt_btn.clicked.connect( | ||
| lambda: self.handle_ztilt() | ||
| ) | ||
| self.panel.cp_z_tilt_btn.clicked.connect(lambda: self.handle_ztilt()) |
| return False | ||
|
|
||
| def add_dot(self): | ||
| def _add_dot(self): |
| def _run_command(self, command): | ||
|
|
||
| def _run_command(self, command: str): |
| ) | ||
|
|
||
| def get_hotspot_ip_via_shell(self, interface: str): | ||
| def get_hotspot_ip_via_shell(self): |
| def on_delete_file(self, filename: str) -> None: ... | ||
| def on_delete_file(self, filename: str) -> None: | ||
| """Handle file deleted""" | ||
| ... |
| # return | ||
| # self._configure_option_cards(_keys) | ||
| if isinstance(config, list): | ||
| ... |
SensorPanel: replace QListWidgetItem with EntryListModelSensorPanel: replace QListWidgetItem with EntryListModel
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
sensorWidget.py: lock toggle_button until action succeeds and replace repaint() with update() for proper refresh Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
lib/panels/widget/sensorPanel.pyPlaces the previous single sensor handling with an
EntryListModelthat tracks multiple active sensors.Each sensor now has its own
EntryListModelinstance, simplifying state management and improving UI consistency.This lays the groundwork for supporting future dynamic sensor sets and cleaner widget logic.
lib/panels/widget/sensorWidget.py:Update interface to conform with new sensor configuration UI.
Adjust layouts and update redraw logic to fix rendering issues.
Screenshots
Future Work