-
Notifications
You must be signed in to change notification settings - Fork 46
chore: Add v25.12gl1 version #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e7ffe5 to
2f2f952
Compare
The `uv pip install -e .` command fails in Docker CI because it requires a virtual environment, but the container uses UV_PROJECT_ENVIRONMENT instead. Since `uv sync` already handles editable installs for workspace packages, this line is redundant and can be safely removed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The pyproject.toml had the script entry point named 'hello' instead of 'clnvm', causing the Dockerfile command to fail when trying to call 'uv run --package cln-version-manager latest --root-path'. Changes: - Renamed script entry point from 'hello' to 'clnvm' in pyproject.toml - Updated Dockerfile to call 'clnvm latest --root-path' via uv run This fixes the docker-ci-build failure at step #31.
The gl-testing container was missing libsodium23, which is required for lightningd to start. This was causing test failures in the Python client tests.
Registering first allows us to avoid the repeated errors about the signer attempting to wait for startup, but the scheduler saying it doesn't know about such a node.
By scheduling the node before we start the signer we can avoid having the signer print its reconnect loop while debugging.
Also fixes the address verification at startup to be handled locally so we don't lock up during init.
We needed a shim since it was renamed inbetween releases.
Add a global --cache option to the CLI that allows users to specify where CLN versions should be stored. This option is propagated to all subcommands via click context. When not specified, the default cache directory is used (determined by CLNVM_CACHE_DIR env var, XDG_CACHE_HOME, or ~/.cache/clnvm). This makes the tool more flexible for use in different contexts, such as downloading versions to a project-local directory.
Add a new 'link' command that creates symlinks in the current working directory pointing to CLN versions in the cache. Usage: clnvm link [VERSION] - Link a specific version clnvm link - Link all available versions The command: - Creates symlinks with the version name (e.g., v24.11.) - Points to the full path in the cache directory - Skips versions that aren't downloaded yet (when linking all) - Reports existing symlinks and non-symlink paths This makes it easy to set up a directory with convenient access to multiple CLN versions without duplicating the binaries.
- gl-plugin: 0.3.0 -> 0.3.1 - gl-sdk: 0.1.0 -> 0.1.1 - gl-cli: 0.1.1 -> 0.1.2 - gl-testing: 0.3.0 -> 0.3.1 Updated CHANGELOGs to indicate support for CLN v25.12 signer.
- gl-client: 0.3.3 - gl-sdk: 0.1.2 - gl-cli: 0.1.3 - gl-client-py: 0.3.5 - gl-sdk-android: 0.1.2 - gl-sdk-swift: 0.1.2
1f242a5 to
53f7ad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.