Created the form to search for the courses by Kevy-loo · Pull Request #326 · BloomTech-Labs/coder-heroes-fe

Kevy-loo · 2022-09-02T21:22:11Z

Description

Created a form where parents can search for available courses when exploring programs for their children.

Co-Authors:

Shanae Leslie - ShanaeL29
Laila Arkadan - lailaarkadan
Kevin Liu - Kevy-loo

Fixes # (issue)

Loom Video

https://www.loom.com/share/c77e0d6d9b674ccab07514954b8235a6

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have removed unnecessary comments/console logs from my code
My changes generate no new warnings
I have checked my code and corrected any misspellings
No duplicate code left within changed files
Size of pull request kept to a minimum

gclancy121 · 2022-09-06T15:12:21Z

Looks good to me, code looks clean

Roadlyfe

Code looks good and clean. nice work!

lisamdespain

Looks really good - you have a lot going on but you implemented it well.

lisamdespain · 2022-09-06T18:02:39Z

src/components/pages/ParentBooking/ParentBookingCard.js

-    subject,
-    description,
+    course_name,
+    course_description,


I think at some point we need to address that times could be different on different days. Example: Monday class could start at 9am, but Tuesday, class starts at 3pm.

lisamdespain · 2022-09-06T18:03:32Z

src/components/pages/ParentBooking/ParentBookingCard.js

-    { title: 'instructor', text: instructor_name },
-    { title: 'class size', text: size },
-  ];
+  // const data = [


Maybe ok to delete instead of commenting it out?

reneetro

I agree the second set of data that is commented out in the ParentBookingCard.js can probably be removed. You may still want to have a key for each ParentBookCard (perhaps item.id?), that might not be necessary though. Everything else looks nice and organized, it would be awesome to have a Loom so we can see what it looks like!

DawsonReschke

Code look great, well written and clean. There was a large object that was commented out, perhaps remove that, otherwise good job!

Austin-T-Johnson

Great job overall, looks like there was a lot implemented on this ticket! I left a few notes in the files changed for your consideration!

Austin-T-Johnson · 2022-09-14T19:51:36Z

src/components/pages/ParentBooking/BookingCalendar.js

+
+const BookingCalendar = () => {
+  const onPanelChange = (value, mode) => {
+    console.log(value.format('YYYY-MM-DD'), mode);


Wondering what this function is intended to do? Looks like currently, it is just console logging the date?

Austin-T-Johnson · 2022-09-14T19:52:35Z

src/components/pages/ParentBooking/ParentBookingCard.js

-      )
+      .post()
      .then(res => console.log(res)) // TODO: Let's perform some action with this result.
      .catch(err => console.log(`message: ${err.message}`));


great job adding a catch to handle errors

Austin-T-Johnson · 2022-09-14T19:53:19Z

src/components/pages/ParentBooking/ParentBookingCard.js

+            <Form className="il__top__form" size={'large'} layout="inline">
+              <Input.Group
+                compact
+                // style={{ display: 'flex', flexDirection: 'column' }}


You might want to remove this commented out code

Austin-T-Johnson · 2022-09-14T19:53:52Z

src/components/pages/ParentBooking/ParentBookingCard.js

+              >
+                <div>
+                  <div
+                    style={{


You might want to consider adding the styling in a separate CSS file to clean up the code a bit

Yes absolutely we were just doing this to prevent switching between screens so much. This is still a draft PR at this point! Thank you!

MaxT6

Nice job creating the form to search for courses. There is a chance to clean up the code but overall the code looks great!

MaxT6 · 2022-09-15T17:25:10Z

src/components/pages/ParentBooking/ParentBookingContainer.js

-                      <ParentBookingCard key={idx} booking={item} />
-                    </div>
+                    <div> */}
+              <ParentBookingCard booking={item} />


Is there a reason this code is commented out?

MaxT6 · 2022-09-15T17:25:42Z

src/styles/calendar.less

    margin: 0 4%;
  }
 }
+//Calendar Card for 


I appreciate the label but what is the calendar card for?

MaxT6 · 2022-09-15T17:26:39Z

src/components/pages/ParentBooking/ParentBookingCard.js

 import axiosWithAuth from '../../../utils/axiosWithAuth';
 import { useOktaAuth } from '@okta/okta-react';
 import { addToCart } from '../../../redux/actions/parentActions';
+import { dummyData } from '../../../dummyData';


Good job labeling your data as such to indicate it will need to change.

I'd go one step further here and indicate. 'what kind of dummyData' it is. Example

dummyUserData etc.

ryan-hamblin · 2022-09-23T20:35:54Z

src/components/pages/ParentBooking/ParentBookingCard.js

+                      }}
+                    >
+                      <button
+                        style={{


Let's make these styles 'DRY' and not inline. :)

Oh yes we plan to export the styles and make them DRY, we were just using everything inline to prevent switching between screens so much while implementing the figma design. We have actually switched to a dropdown on our current branch. We are implementing ant design styles as well! Thank you for your input Ryan!

ryan-hamblin

I noticed in ParentBookingChild that we're already customizing buttons using inline styles. Let's not do the styles inline, and I would heavily consider the use of AntD's buttons here. Always stick with the easiest path which in this case, is to use the built in library for styling. No need to reinvent button right?

AlexiusThomas

Great code but I definitely see the areas of improvement.

AlexiusThomas

i see that testing has started and all checks passed. That is good

Created the form to search for the courses

d320b5e

lailaarkadan assigned ShanaeL29 and lailaarkadan Sep 2, 2022

Roadlyfe previously approved these changes Sep 6, 2022

View reviewed changes

lisamdespain previously approved these changes Sep 6, 2022

View reviewed changes

implemented design from figma

82685b7

lailaarkadan dismissed stale reviews from lisamdespain and Roadlyfe via 82685b7 September 9, 2022 04:24

reneetro previously approved these changes Sep 9, 2022

View reviewed changes

DawsonReschke previously approved these changes Sep 12, 2022

View reviewed changes

Austin-T-Johnson reviewed Sep 14, 2022

View reviewed changes

MaxT6 reviewed Sep 15, 2022

View reviewed changes

added dynamic btns

bac3f41

ryan-hamblin reviewed Sep 23, 2022

View reviewed changes

connected program and date selections to display available courses.

1110bd1

lailaarkadan dismissed stale reviews from DawsonReschke and reneetro via 1110bd1 September 27, 2022 02:24

Kevy-loo and others added 4 commits October 4, 2022 14:15

fixed available courses select functionality

5d03e4a

Merge branch 'main' into Bl476_form

4eae0eb

testing

4d24d56

moved inline styles to booking.less file and made styling edit

dfd7bb7

AlexiusThomas reviewed Oct 9, 2022

View reviewed changes

in the process of making it responsive

d210d72

paulstgermain closed this Nov 29, 2022

paulstgermain reopened this Nov 29, 2022

lailaarkadan and others added 3 commits December 7, 2022 16:20

commenting out media queries to implement ant design

85bd9a2

Ant Design Grid starter implementation

7412fe3

removed commented out code

2428627

testing

0bb15b6

AlexiusThomas approved these changes Dec 15, 2022

View reviewed changes

Kevy-loo marked this pull request as ready for review December 16, 2022 19:29

Conversation

Kevy-loo commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Loom Video

Type of change

Checklist:

Uh oh!

gclancy121 commented Sep 6, 2022

Uh oh!

Roadlyfe left a comment

Choose a reason for hiding this comment

Uh oh!

lisamdespain left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reneetro left a comment

Choose a reason for hiding this comment

Uh oh!

DawsonReschke left a comment

Choose a reason for hiding this comment

Uh oh!

Austin-T-Johnson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MaxT6 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ShanaeL29 Sep 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryan-hamblin left a comment

Choose a reason for hiding this comment

Uh oh!

AlexiusThomas left a comment

Choose a reason for hiding this comment

Uh oh!

AlexiusThomas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Comments

Kevy-loo commented Sep 2, 2022 •

edited

Loading

ShanaeL29 Sep 23, 2022 •

edited

Loading