Skip to content

[PW_SID:1046242] [06/21] Bluetooth: btintel_pcie: Use IRQF_ONESHOT and default primary handler #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BluezTestBot wants to merge 2 commits into
base: workflow
Choose a base branch
from
Open

[PW_SID:1046242] [06/21] Bluetooth: btintel_pcie: Use IRQF_ONESHOT and default primary handler #3275

BluezTestBot wants to merge 2 commits into from

Conversation

@BluezTestBot
Copy link
Owner

@BluezTestBot BluezTestBot commented Jan 23, 2026

There is no added value in btintel_pcie_msix_isr() compared to
irq_default_primary_handler().
Using a threaded interrupt without a dedicated primary handler mandates
the IRQF_ONESHOT flag to mask the interrupt source while the threaded
handler is active. Otherwise the interrupt can fire again before the
threaded handler had a chance to run.

Use the default primary interrupt handler by specifying NULL and set
IRQF_ONESHOT so the interrupt source is masked until the secondary
handler is done.

Cc: Marcel Holtmann marcel@holtmann.org
Cc: Luiz Augusto von Dentz luiz.dentz@gmail.com
Cc: linux-bluetooth@vger.kernel.org
Fixes: c2b636b ("Bluetooth: btintel_pcie: Add support for PCIe transport")
Signed-off-by: Sebastian Andrzej Siewior bigeasy@linutronix.de

drivers/bluetooth/btintel_pcie.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

tedd-an and others added 2 commits January 21, 2026 22:03
@tedd-an
workflow: Add workflow files for ci
f6b7f11 
This patch adds workflow files for ci:

[sync.yml]
 - The workflow file for scheduled work
 - Sync the repo with upstream repo and rebase the workflow branch
 - Review the patches in the patchwork and creates the PR if needed

[ci.yml]
 - The workflow file for CI tasks
 - Run CI tests when PR is created

Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
@tedd-an
Bluetooth: btintel_pcie: Use IRQF_ONESHOT and default primary handler
6c1a625 
There is no added value in btintel_pcie_msix_isr() compared to
irq_default_primary_handler().
Using a threaded interrupt without a dedicated primary handler mandates
the IRQF_ONESHOT flag to mask the interrupt source while the threaded
handler is active. Otherwise the interrupt can fire again before the
threaded handler had a chance to run.

Use the default primary interrupt handler by specifying NULL and set
IRQF_ONESHOT so the interrupt source is masked until the secondary
handler is done.

Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Fixes: c2b636b ("Bluetooth: btintel_pcie: Add support for PCIe transport")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
@github-actions
Copy link

github-actions bot commented Jan 23, 2026

CheckPatch
Desc: Run checkpatch.pl script
Duration: 0.33 seconds
Result: PENDING

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

GitLint
Desc: Run gitlint
Duration: 0.26 seconds
Result: PENDING

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

SubjectPrefix
Desc: Check subject contains "Bluetooth" prefix
Duration: 0.09 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

BuildKernel
Desc: Build Kernel for Bluetooth
Duration: 25.25 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

CheckAllWarning
Desc: Run linux kernel with all warning enabled
Duration: 28.14 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

CheckSparse
Desc: Run sparse tool with linux kernel
Duration: 30.88 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

BuildKernel32
Desc: Build 32bit Kernel for Bluetooth
Duration: 24.81 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

TestRunnerSetup
Desc: Setup kernel and bluez for test-runner
Duration: 554.38 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

TestRunner_l2cap-tester
Desc: Run l2cap-tester with test-runner
Duration: 34.71 seconds
Result: FAIL
Output:

Total: 96, Passed: 91 (94.8%), Failed: 5, Not Run: 0

Failed Test Cases
L2CAP LE Client - Set PHY 1M                         Failed       2.164 seconds
L2CAP LE Client - Set PHY 2M                         Failed       2.168 seconds
L2CAP Ext-Flowctl Client - Set PHY 1M                Failed       0.160 seconds
L2CAP Ext-Flowctl Client - Set PHY 2M                Failed       2.176 seconds
L2CAP Ext-Flowctl Client - Set PHY Coded             Failed       0.176 seconds

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

TestRunner_iso-tester
Desc: Run iso-tester with test-runner
Duration: 53.44 seconds
Result: FAIL
Output:

BUG: KASAN: slab-use-after-free in le_read_features_complete+0x7e/0x2b0
Total: 141, Passed: 141 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

TestRunner_bnep-tester
Desc: Run bnep-tester with test-runner
Duration: 6.44 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

TestRunner_mgmt-tester
Desc: Run mgmt-tester with test-runner
Duration: 124.17 seconds
Result: FAIL
Output:

Total: 494, Passed: 487 (98.6%), Failed: 3, Not Run: 4

Failed Test Cases
Read Exp Feature - Success                           Failed       0.105 seconds
LL Privacy - Add Device 3 (AL is full)               Failed       0.197 seconds
LL Privacy - Set Flags 2 (Enable RL)                 Failed       0.158 seconds

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

TestRunner_rfcomm-tester
Desc: Run rfcomm-tester with test-runner
Duration: 9.46 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

TestRunner_sco-tester
Desc: Run sco-tester with test-runner
Duration: 14.60 seconds
Result: FAIL
Output:

WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

TestRunner_ioctl-tester
Desc: Run ioctl-tester with test-runner
Duration: 10.27 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

TestRunner_mesh-tester
Desc: Run mesh-tester with test-runner
Duration: 12.43 seconds
Result: FAIL
Output:

Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.692 seconds
Mesh - Send cancel - 2                               Timed out    1.999 seconds

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

TestRunner_smp-tester
Desc: Run smp-tester with test-runner
Duration: 8.52 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

TestRunner_userchan-tester
Desc: Run userchan-tester with test-runner
Duration: 6.72 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

IncrementalBuild
Desc: Incremental build with the patches in the series
Duration: 0.55 seconds
Result: PENDING

@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from 3f966d4 to ea4e59a Compare January 26, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BluezTestBot @tedd-an