fix: rate-limit comment API calls#1
Open
seth-martin-bold-penguin wants to merge 2 commits into
Open
Conversation
…ndary rate limits
Member
|
Can you instead update the source, and rebuild the dist part? https://github.com/BoldPenguin/cdk-diff-action/blob/main/src/stage-processor.ts#L246 |
seth-martin-bold-penguin
force-pushed
the
fix/rate-limit-comments
branch
from
f24b813 to
78b05e4
Compare
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| failed.push(e); | ||
| } | ||
| // Rate limit: wait 200ms between API calls to avoid GitHub secondary rate limits | ||
| await new Promise(resolve => setTimeout(resolve, 200)); |
There was a problem hiding this comment.
What you think about not commenting per Stack at all, which is too many comments.
There was a problem hiding this comment.
May be we can just truncate? and do a manual review. We have too many stacks. I'd add an attribute to the acton supressCommentPerStack -- we disable that, and the post 1 comment per stage, message too long review from local or something like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When CDK diff output is too large for a single PR comment, the action falls back to one comment per stack. It fires ALL comment API calls in parallel via
Promise.allSettled, hitting GitHub's secondary rate limit with 100+ stacks.Fix: Replace parallel
Promise.allSettledwith sequential execution + 200ms delay between API calls.How did you test this?
Will validate via cdk-infra PR.