Skip to content

AB#16 Fixing Code Quality Notes - part 4. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BlaiseD merged 1 commit into from
Feb 4, 2026
Merged

AB#16 Fixing Code Quality Notes - part 4. #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...entModel.Serialization/ComponentModel/Serialization/WorkflowMarkupSerializationManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,8 @@ public virtual Type GetType(XmlQualifiedName xmlQualifiedName)
}
catch (Exception ex) when (!ExceptionUtility.IsCriticalException(ex))
{
// Intentionally ignore non-critical exceptions when resolving the type.
// Fallback logic below will handle the case where resolvedType remains null.
}

if (resolvedType == null)
Expand Down Expand Up @@ -244,6 +246,8 @@ public virtual Type GetType(string typeName)
}
catch (Exception ex) when (!ExceptionUtility.IsCriticalException(ex))
{
// Intentionally ignore non-critical exceptions when resolving the type.
// Fallback logic below will handle the case where type remains null.
}
}

Expand Down Expand Up @@ -273,6 +277,8 @@ public virtual Type GetType(string typeName)
}
catch (Exception ex) when (!ExceptionUtility.IsCriticalException(ex))
{
// Intentionally ignore non-critical exceptions when the assembly cannot be loaded.
// Fallback logic below will handle the case where assembly is null.
}
}

Expand Down
4 changes: 2 additions & 2 deletions ...low.ComponentModel.Serialization/ComponentModel/Serialization/WorkflowMarkupSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,9 +1394,9 @@ private void DeserializeCompoundProperty(WorkflowMarkupSerializationManager seri
{
property.SetValue(obj, propValue, null);
}
catch
catch (Exception ex) when (!ExceptionUtility.IsCriticalException(ex))
{
serializationManager.ReportError(new WorkflowMarkupSerializationException(SR.GetString(SR.Error_SerializerComplexPropertySetFailed, [propertyName, propertyName, obj.GetType().Name])));
serializationManager.ReportError(new WorkflowMarkupSerializationException(SR.GetString(SR.Error_SerializerComplexPropertySetFailed, [propertyName, propertyName, obj.GetType().Name]), ex));
}
}
}
Expand Down