Skip to content

AB#16 Removing test which invokes mapping.Equals(null);. Removing al… #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BlaiseD merged 1 commit into from
Feb 4, 2026
Merged

AB#16 Removing test which invokes mapping.Equals(null);. Removing al… #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions ...low.ComponentModel.Serialization/ComponentModel/Serialization/WorkflowMarkupSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1401,16 +1401,14 @@ private void DeserializeCompoundProperty(WorkflowMarkupSerializationManager seri

if (propValue != null && propValue.GetType() == typeof(string) && ((string)propValue).StartsWith("{}", StringComparison.Ordinal))
propValue = ((string)propValue).Substring(2);
if (property != null)

try
{
try
{
property.SetValue(obj, propValue, null);
}
catch
{
serializationManager.ReportError(new WorkflowMarkupSerializationException(SR.GetString(SR.Error_SerializerComplexPropertySetFailed, new object[] { propertyName, propertyName, obj.GetType().Name })));
}
property.SetValue(obj, propValue, null);
}
catch
{
serializationManager.ReportError(new WorkflowMarkupSerializationException(SR.GetString(SR.Error_SerializerComplexPropertySetFailed, new object[] { propertyName, propertyName, obj.GetType().Name })));
}
}
}
Expand Down
18 changes: 0 additions & 18 deletions ...l.Serialization.Tests/ComponentModel/Serialization/WorkflowMarkupSerializerMappingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,24 +373,6 @@ public void Equals_WithDifferentUnifiedAssemblyName_ReturnsFalse()
Assert.False(result);
}

[Fact]
[SuppressMessage("Style", "CA1062:Validate arguments of public methods", Justification = "Testing explicit null handling")]
public void Equals_WithNull_ReturnsFalse()
{
// Arrange
var mapping = new WorkflowMarkupSerializerMapping(
"prefix",
"http://test.namespace.com",
"TestNamespace",
"TestAssembly");

// Act
var result = mapping.Equals(null);

// Assert
Assert.False(result);
}

[Fact]
public void Equals_WithSameUnifiedAssemblyName_ReturnsTrue()
{
Expand Down