Skip to content

Conversation

@jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Dec 13, 2025

GH Actions/test: rename matrix variable [1]

The matrix.php-versions variable will only ever contain a single PHP version number when used in the steps of the job, so the name was confusing.

Fixed now.

GH Actions/test: rename matrix variable [2]

And while I'm at it, may as well rename the dependency-versions to dependencies.

The `matrix.php-versions` variable will only ever contain a single PHP version number when used in the steps of the job, so the name was confusing.

Fixed now.
And while I'm at it, may as well rename the `dependency-versions` to `dependencies`.
@jrfnl jrfnl added this to the 2.7.0 milestone Dec 13, 2025
@jrfnl jrfnl requested a review from gmazzap December 13, 2025 10:49
@jrfnl jrfnl added the github_actions Pull requests that update GitHub Actions code label Dec 13, 2025
@jrfnl
Copy link
Collaborator Author

jrfnl commented Dec 13, 2025

@gmazzap FYI: the action pinning PR would conflict with this PR, so I will pull that PR once this one has been merged.

@gmazzap gmazzap merged commit 5d2aea1 into master Dec 14, 2025
66 checks passed
@gmazzap gmazzap deleted the feature/ghactions-test-job-rename-vars branch December 14, 2025 13:04
@gmazzap
Copy link
Contributor

gmazzap commented Dec 14, 2025

Thank you @jrfnl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants