Ux/foundation#47
Conversation
Julesc27
added
enhancement
|
I would not recommend merging this into |
|
Also, it's worth noting that this probably shouldn't have the "high priority" label as revamping the UX is not part of the MVP. |
Julesc27
removed
the
high priority
| const role = (user.display_role || "").toLowerCase(); | ||
| return role === "super_admin" || role === "superadmin" || role === "super admin"; |
There was a problem hiding this comment.
This seems pretty silly. The superadmin role should always grant superuser, making this extra layer unnecessary.
| <BrandSub style={{ marginTop: 6 }}> | ||
| George M. Low Center for Industrial | ||
| </BrandSub> | ||
| <BrandSub>Innovation (CII), Room 2037A</BrandSub> |
There was a problem hiding this comment.
This feels like an excessive degree of splitting into components - I feel like judicious use of line breaks would be semantically better here. Not like adamantly opposed to how it is, just feels a bit excessive.
4 participants
This is the first of MANY PR's that need to be made for the new ux design of the forge website. This branch is needed so that all of my other branches that will be created can utilized the same repetitive code (ex: images, nav bar, footer etc.). This PR does make the website look weird but trust the process this is kind of the only way i can do this without creating a super master branch of the ux design that I accidentally made.
This branch contains only frontend changes so the backend has not been touch. It contains many different images that I will be using during the new re design. It also contains the nav bar which contains these tabs: create, status, hours, FAQ with a dropdown of Etiquette, materials information and about us. There is also the sign in which will link a drop down of summary and logout. If someone has the admin role there will be an additional nav bar link called admin.
here's more of an explanation of each page
create: this is a new page that can help new people navigate the forge better. it has a bunch of information and different steps for users to take in order to be successful before coming into the forge. this includes file types, machines, materials, hours of operation and creating and account.
status: same idea different design
hours: same idea different design
FAQ: I personally and some other people agree that wiki is a bad name for a FAQ page so we decided on having a dropdown that is at the moment linked to 3 different pages Etiquette which is a do's and don'ts page that has some information that was requested by a room manager. Materials information which is a page dedicated to all of the different materials that can and can't be used in the space. it has our prices on materials as well. then there is the about us page it'll be a simple straight forward page
admin: the admin page will be a page that has all of the admin sheets are requirements that are needed for the admin stuff such as machine groups and semesters. basically just moving it from the users forge account to having its own separate tab if someone has that permission
More explanation will be made when the new branches/pages can be committed
if you go to the branch that is called new-uxdesign it has basically the whole idea that will be the new site. some issues are still being fixed but that's the bigger picture.