Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Brenna,
I took a look through your code and left a few comments -- lots of it is looking great, in particular your server! You mentioned when you submitted your homework that you wanted to talk with someone about how everything fit together, and I think we helped you with some of it but not all -- if you'd ever like to think back on some of this stuff as a review, feel free to come to office hours or set up a meeting with us (talking through it again would probably be a great review for us too).
I also created a
package.jsonfile withnpm init-- when you install dependencies with the--saveflag they'll show up in the "dependencies" list there, and that way someone who pulls your app from Github (e.g. me) can runnpm installto create anode_modulesfolder with everything your app depends on.Remember not to merge these pull requests -- take a look at the feedback, feel free to comment if you'd like to discuss anything, and then close the PR.