Skip to content

[DO NOT MERGE] - Adjust d2l-page to handle consumers wanting to use flex #7214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
svanherk wants to merge 1 commit into
base: comms-example-1
Choose a base branch
from
+10 −1
Draft

[DO NOT MERGE] - Adjust d2l-page to handle consumers wanting to use flex #7214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/page/demo/page-component-comms-app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class PageDemoCommsApp extends LitElement {
box-sizing: border-box;
display: flex;
flex-direction: column;
min-height: calc(100vh - var(--d2l-page-header-height-measured) - 70px - 75px); /* sticky header is 70px and input box is 75px */
height: 100%;
justify-content: end;
}

Expand Down
9 changes: 9 additions & 0 deletions components/page/page-main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@ import { PagePanelMixin, pagePanelStyles } from './page-panel-mixin.js';
class PageMain extends PagePanelMixin(LitElement) {

static styles = [pagePanelStyles, css`
:host {
display: flex;
flex-direction: column;
height: 100%;
}
.panel {
box-sizing: border-box;
flex: 1 0 auto;
}
.panel-header {
top: var(--d2l-page-header-height, 0);
}
Expand Down
Loading