Skip to content

GAUD-10314 - Simplify the z-index in POC #7236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
svanherk wants to merge 3 commits into
base: GAUD-10314-legacy-browser-mode
Choose a base branch
from
+17 −2
Draft

GAUD-10314 - Simplify the z-index in POC #7236

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc3a722
GAUD-10314 - Simplify the z-index in POC
svanherk Jul 17, 2026
05dd038
Adjustments
svanherk Jul 17, 2026
4057e0d
Merge branch 'GAUD-10314-legacy-browser-mode' into GAUD-10314-simplif…
svanherk Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions components/page/page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ class Page extends ProviderMixin(LocalizeCoreElement(LitElement)) {

.header {
position: relative;
z-index: 15; /* To be over sticky content of our core components */
z-index: 2; /* Ensures the header is over the divider */
}

.page.header-sticky .header {
Expand All @@ -140,6 +140,7 @@ class Page extends ProviderMixin(LocalizeCoreElement(LitElement)) {
main {
--d2l-page-main-sticky-top: var(--d2l-page-header-height, 0);
flex: 1;
isolation: isolate;
min-width: min(${MAIN_MIN_WIDTH}px, 100%);
}

Expand All @@ -161,6 +162,10 @@ class Page extends ProviderMixin(LocalizeCoreElement(LitElement)) {
overflow: clip auto;
}

.divider {
z-index: 1; /* Ensures the divider is over the panels */
}

.footer:not([hidden]),
.floating-buttons-container {
display: inline;
Expand All @@ -171,7 +176,7 @@ class Page extends ProviderMixin(LocalizeCoreElement(LitElement)) {
inset: auto 0 0;
padding-block-start: 0.75rem;
position: fixed;
z-index: 10; /* To be over sticky content of our core components */
z-index: 1; /* Ensures the footer is over the divider */
}
.footer-contents {
margin-inline: var(--d2l-page-margin-inline, 0);
Expand All @@ -184,6 +189,9 @@ class Page extends ProviderMixin(LocalizeCoreElement(LitElement)) {
flex-direction: column;
height: 100vh;
}
.page.legacy-browser-mode .header {
z-index: 16; /* To be over sticky content of our core components and divider */
}
.page.legacy-browser-mode.has-panels .header,
.page.legacy-browser-mode.header-sticky.has-panels .header {
flex: 0 0 auto;
Expand All @@ -196,6 +204,9 @@ class Page extends ProviderMixin(LocalizeCoreElement(LitElement)) {
padding-bottom: 0;
width: 100%;
}
.page.legacy-browser-mode main {
isolation: auto;
}
.page.legacy-browser-mode.has-panels main {
--d2l-page-main-sticky-top: 0; /* Header is static and content scrolls within main, so panel headers stick to the top of the scroll container */
min-height: 0;
Expand All @@ -208,11 +219,15 @@ class Page extends ProviderMixin(LocalizeCoreElement(LitElement)) {
min-height: 0;
position: static;
}
.page.legacy-browser-mode .divider {
z-index: 15; /* To be over sticky content of our core components */
}
.page.legacy-browser-mode.has-panels .footer {
flex: 0 0 auto;
}
.page.legacy-browser-mode.has-panels .fixed-footer {
position: static;
z-index: 15; /* To be over sticky content of our core components and divider */
}
`;

Expand Down
Loading