Implement Comprehensive Authentication & Access Control System #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Attach screenshots, please? |
Contributor
Author
|
alright i will do just that |
Contributor
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #23
What's Included:
✅ Email/password login with JWT
✅ Starknet wallet authentication
✅ Role-based access control (Admin/User roles)
✅ Secure guards for protected routes
Key Files:
user.entity.ts (User model with roles)
auth.service.ts (Login logic)
jwt-auth.guard.ts (Token validation)
roles.guard.ts (Permission checks)
How to Test:
Email login: POST /auth/login
Wallet login: POST /auth/wallet-login
Try accessing GET /admin (Admin role required)
Notes:
Requires adding JWT_SECRET to .env
DB migration adds roles column to users