2.1.8 PR by gurudevtest · Pull Request #9 · BugBash-Test/zuul

gurudevtest · 2022-04-07T00:35:46Z

No description provided.

…ing generated Java files. (#791) While Gradle worked fine with the existing code, IntelliJ does not. IntelliJ's incremental compilation does not include the full classpath, making most of the files in the Filter class not available. The generated file thus changes frequently and prevents running from the IDE. JetBrains considers this a feature, and will not change it. Work around this by generating a list of classes, which is appended, rather than created from scratch each compilation. This allows incremental compilation in IntelliJ to keep running at the cost of potentially having stale filters listed.

Travis CI made a change in how it pulls git repos, which no longer includes all tags. This means the version can't be inferred, causing releases and snapshots to use version 0.0.1. Pin the version for now, which is how other OSS projects work.

…800) This reverts commit 9e0adb0. It was not the issue

make use of adjust retry policy method before retrying

… type incorrectly

add ability to provide headers on request rejection

https://blog.gradle.org/gradle-wrapper-checksum-verification-github-action

* build(deps): bump actions/setup-java from v1 to v2 Bumps [actions/setup-java](https://github.com/actions/setup-java) from v1 to v2. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v1...8764a52) Signed-off-by: dependabot[bot] <support@github.com> * Fix PR to include required field Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Carl Mastrangelo <cmastrangelo@netflix.com>

Bumps [actions/cache](https://github.com/actions/cache) from v2 to v2.1.4. - [Release notes](https://github.com/actions/cache/releases) - [Commits](actions/cache@v2...26968a0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…" (#1042) This reverts commit 9102c93.

Simplify read timeout functionality and move to using Duration

This PR changes LOG.warn to LOG.debug in ClientResponseWriter Motivation: We have observed a large number of WARN messages in production. The log message that occurs most frequently is Received complete event while still handling the request. With reason: CLOSE

* Tests for completion event reason

Fix potential NPE in ProxyEndpoint

This is needed to run on later JDKs than 11, as it uses a better maintained classfile generator. From my reading, it is API compatible with Guice 4.2.

Fix issue

Update Server.java

gurudevtest

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.

gurudevtest · 2022-04-07T00:39:53Z

zuul-core/src/main/java/com/netflix/zuul/netty/server/Server.java

+    static Map<NamedSocketAddress, ChannelInitializer<?>> convertPortMap(
            Map<Integer, ChannelInitializer<?>> portsToChannelInitializers) {
-        Map<SocketAddress, ChannelInitializer<?>> addrsToInitializers =
+        Map<NamedSocketAddress, ChannelInitializer<?>> addrsToInitializers =


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

The HashMap constructor rehashes your hash table after 75% of all keys have been added to the table. To improve performance and prevent rehashing, use the Guava newHashMapWithExpectedSize() method. See the following diffs on GitHub that make this code change: diff1, diff2

Learn more: HashMap constructor in the Java Platform Standard Edition 8 API Specification and the newHashMapWithExpectedSize in the Guava: Google Core Libraries for Java 23.0 API

gurudevtest · 2022-04-07T00:39:54Z

...-core/src/main/java/com/netflix/netty/common/proxyprotocol/HAProxyMessageChannelHandler.java

+    static final Attrs.Key<Integer> HAPM_DEST_PORT = Attrs.newKey("hapm_port");
+
+    @Override
+    public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

This method contains 47 lines of code, not including blank lines or lines with only comments, Java punctuation characters, identifiers, or literals. By comparison, 98% of the methods in the CodeGuru reference dataset contain fewer lines of code. Large methods might be difficult to read and have logic that is hard to understand and test. We recommend that you simplify this method or break it into multiple methods.

gurudevtest · 2022-04-07T00:39:54Z

...re/src/main/java/com/netflix/zuul/netty/server/http2/Http2ContentLengthEnforcingHandler.java

+     * </ul>
+     */
+    @Override
+    public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

The cyclomatic complexity of this method is 13. By comparison, 98% of the methods in the CodeGuru reference dataset have a lower cyclomatic complexity. This indicates the method has a high number of decisions and it can make the logic difficult to understand and test.

We recommend that you simplify this method or break it into multiple methods. For example, consider extracting the code block on lines 74-82 into a separate method.

gurudevtest · 2022-04-07T00:39:54Z

zuul-core/src/main/java/com/netflix/netty/common/throttle/RejectionUtils.java

+     * @param rejectedBody the HTTP body to be sent back.  It is assumed to be of type text/plain.
+     * @param rejectionHeaders additional HTTP headers to add to the rejection response
+     */
+    public static void handleRejection(


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

The cyclomatic complexity of this method is 12. By comparison, 98% of the methods in the CodeGuru reference dataset have a lower cyclomatic complexity. This indicates the method has a high number of decisions and it can make the logic difficult to understand and test.

We recommend that you simplify this method or break it into multiple methods. For example, consider extracting the code block on lines 167-178 into a separate method.

Vishnu-Amazon

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.

gurudevtest

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.

carl-mastrangelo and others added 30 commits April 15, 2020 10:55

zuul-core: avoid warnspam on SSL connections

3a237bd

all: run CI with JDK14

6373b6e

all: use Mockito 3

0770a85

zuul-sample: fix module installation

3928932

all: fix license exclude rules

3988f9b

zuul-guice: fix lint warnings on test

3c6bf8f

zuul-core: fix javadoc lint warnings

37b6c6e

all: bump to groovy 3.0.3

4b9ee15

all: bump guava to 29.0

3ac48f1

zuul-guice: avoid AOP build to reduce jdk11 warnings

1403911

zuul-core: make address selection logic overridable

e031117

all: roll back groovy dep as it seems to break publishing

9e0adb0

all: pin version

ff934c2

Travis CI made a change in how it pulls git repos, which no longer includes all tags. This means the version can't be inferred, causing releases and snapshots to use version 0.0.1. Pin the version for now, which is how other OSS projects work.

zuul-core,zuul-groovy: split groovy support to a separate package

14cbe44

zuul-core: avoid using servo api in direct memory monitor

cab193e

zuul-core: fix direct memory usage by passing non-null ref

1742abb

Revert "all: roll back groovy dep as it seems to break publishing" (#…

269a9dc

…800) This reverts commit 9e0adb0. It was not the issue

zuul-core: bump jmh to 1.23

49abcdd

zuul-core: avoid using servo api in ServerChannelMetrics

9615f98

zuul-core: remove a few more servo refs

98d91c5

make use of adjust retry policy method before retrying

fe5c5b1

Merge pull request #806 from Netflix/adjust-retry-policy

84da02a

make use of adjust retry policy method before retrying

zuul-core: make filterOrder, type, and sync derived from the annotations

d700e2f

zuul-core: revert passport changes, as the parent class overrides the…

d9f67b5

… type incorrectly

zuul-core: allow expressing ApplyBefore rules

41ceed1

add ability to provide headers on request rejection

85998d0

update javadocs

a8e091c

more javadoc updates

dbdc246

Merge pull request #809 from Netflix/rejection-headers

cf8bff8

add ability to provide headers on request rejection

carl-mastrangelo and others added 27 commits March 31, 2021 10:05

all: update to netty 4.1.62 (#1036)

2e31fab

all: update to netty 4.1.63

53aa752

chore: enable Gradle wrapper validation in release.yml (#1025)

a0cf67d

https://blog.gradle.org/gradle-wrapper-checksum-verification-github-action

Cleanup star imports

dc4d229

zuul-guice: use later guice which doesnt need aop work around

9102c93

Revert "zuul-guice: use later guice which doesnt need aop work around…

79301af

…" (#1042) This reverts commit 9102c93.

Merge pull request #1031 from Netflix/simplify-timeouts

941711a

Simplify read timeout functionality and move to using Duration

Set statuscategory explicitly for http pipelining

6b36e09

Remove unnecessary event propagation

de3a03b

Defer to localAddress since bind doesn't rely on it

8e99f22

Tests for completion event reason (#1047)

d08b812

* Tests for completion event reason

fix NPE

941a79b

try a different approach to fix null chosenServer

1ce5cb0

Merge pull request #1049 from Netflix/fixnpeproxyedpt

f7e1e88

Fix potential NPE in ProxyEndpoint

zuul-guice: update to Guice 5 (#1050)

530adfb

This is needed to run on later JDKs than 11, as it uses a better maintained classfile generator. From my reading, it is API compatible with Guice 4.2.

Begin 2.3.1-snapshot (#1052)

2ca73f0

zuul-core: add ability to create trusted origin name authority (#1055)

3f8e4ee

Add a basic builder for request message (#1056)

e22dc37

zuul-core: Add overload for OriginName trust

56fa761

Bug Fixed

6a26ade

Fix issue

ab96792

Merge pull request #1 from BugBash-Test/Test

aeb6f71

Fix issue

Update Server.java

67fde95

Merge pull request #3 from BugBash-Test/gurudevtest-patch-2

9cbaa0b

Update Server.java

gurudevtest commented Apr 7, 2022

View reviewed changes

Vishnu-Amazon reviewed Apr 7, 2022

View reviewed changes

gurudevtest commented Apr 7, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2.1.8 PR#9

2.1.8 PR#9
gurudevtest wants to merge 294 commits into2.1.8from
master

gurudevtest commented Apr 7, 2022

Uh oh!

gurudevtest left a comment

Uh oh!

gurudevtest Apr 7, 2022

Uh oh!

gurudevtest Apr 7, 2022

Uh oh!

gurudevtest Apr 7, 2022

Uh oh!

gurudevtest Apr 7, 2022

Uh oh!

Vishnu-Amazon left a comment

Uh oh!

gurudevtest left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

gurudevtest commented Apr 7, 2022

Uh oh!

gurudevtest left a comment

Choose a reason for hiding this comment

Uh oh!

gurudevtest Apr 7, 2022

Choose a reason for hiding this comment

Uh oh!

gurudevtest Apr 7, 2022

Choose a reason for hiding this comment

Uh oh!

gurudevtest Apr 7, 2022

Choose a reason for hiding this comment

Uh oh!

gurudevtest Apr 7, 2022

Choose a reason for hiding this comment

Uh oh!

Vishnu-Amazon left a comment

Choose a reason for hiding this comment

Uh oh!

gurudevtest left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants