This repository was archived by the owner on Dec 20, 2023. It is now read-only.
Adding defaultPrimaryKeyType and parseInt8 options#144
Merged
Conversation
aheuermann
added a commit
that referenced
this pull request
Mar 2, 2016
Adding defaultPrimaryKeyType and parseInt8 options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defaultPrimaryKeyTypewill only be used if the type is not specified.parseInt8will parse the bigints and throw an error if not a "safe" integer. Right now this kills the process since they are not caught. I submit two PRs which I think will fix this though (brianc/node-postgres#954 and brianc/node-pg-native#41).Both changes are opt-in so no issues with backwards compatibility. Will also back-port this and create a
0.9.7release.@doug-martin @dustinsmith1024