Conversation
There was a problem hiding this comment.
Pull request overview
Updates the private INS GraphQL API and backing data fetcher to use dataset_uuid instead of dataset_source_id when requesting dataset details and associated files.
Changes:
- Added
dataset_uuidto theDatasetDetailsGraphQL type. - Updated
datasetDetailsandgetDatasetFilesquery arguments fromdataset_source_idtodataset_uuid. - Updated
PrivateESDataFetcherto read/filter/sort usingdataset_uuidfor dataset details and file retrieval.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/resources/graphql/ins-private-es.graphql | Switches datasetDetails/getDatasetFiles query arguments to dataset_uuid and exposes dataset_uuid on DatasetDetails. |
| src/main/java/gov/nih/nci/bento_ri/model/PrivateESDataFetcher.java | Updates dataset details and file queries to use dataset_uuid and includes it in returned dataset details. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updated dataset identifier
Change Details (Specifics)
Replaced dataset_source_id with dataset_uuid for dataset details and files
Related Ticket(s)
https://tracker.nci.nih.gov/browse/INS-1581