Fix OOB read/write in Teletext G0 charset remapping #1980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Summary
This PR fixes an out-of-bounds read/write in the Teletext decoder, specifically in the function
remap_g0_charset(uint8_t c).Root Cause
cwas used as an index intoG0_LATIN_NATIONAL_SUBSETS_MAP(size 56) without bounds checking.mwas then used as an index into another table (size 14) without validation.Fix
candm.Impact
fixed Issue: #1979