fix: add NULL checks to Rust FFI exports #1984
Closed
+82
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Description
While reviewing the Rust FFI layer, I noticed several exported functions that
dereference raw pointers coming from C without checking for
NULL.If these functions are ever called with invalid inputs, this can lead to
undefined behavior.
I’m still learning Rust FFI, so please correct me if I’m misunderstanding
anything, but based on my understanding these look like genuine safety issues.
What this PR changes
NULLchecks to Rust FFI exports in:libccxr_exports/mod.rslibccxr_exports/bitstream.rsccxr_verify_crc320orNULL) instead of causing UBNULLpointersTesting
cargo testinsrc/rustfixed #1983