Conversation
…ean.leader.election.enable, and commentary updates.
jolson490
requested review from
EmmanuelNwa247,
cmansky,
mww59,
rin-skylight and
szamfir-skylight
as code owners
|
szamfir-skylight
approved these changes
May 7, 2026
Contributor
szamfir-skylight
left a comment
szamfir-skylight
left a comment
There was a problem hiding this comment.
Looks good. Thanks for looking into all of this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary purpose of this PR is to add validation checks to some variables for the
mskmodule.The only minor functional changes made by this PR are:
MinISRis set to one less thanRFunclean.leader.election.enabletofalse