Skip to content

chore: consolidate SourceSet variants into PopulationRange #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cdc-as81 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: consolidate SourceSet variants into PopulationRange #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
625faaa
chore: consolidate SourceSet variants into PopulationRange
cdc-as81 Mar 26, 2026
5241a84
fix: PopulationIterator
cdc-as81 Apr 1, 2026
7ee3c0c
chore: fix issue with implementation
cdc-as81 Apr 7, 2026
96fa63e
fix: review comments
cdc-as81 Apr 9, 2026
74cd935
fix: broken build
cdc-as81 Apr 10, 2026
1b990f4
Merge branch 'main' into cdc-as81-add-population-range-source-set
cdc-as81 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/entity/context_extension.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ impl ContextEntitiesExt for Context {
// Special case the empty query, which creates a set containing the entire population.
if query.type_id() == TypeId::of::<()>() {
warn!("Called Context::with_query_results() with an empty query. Prefer Context::get_entity_iterator::<E>() for working with the entire population.");
callback(EntitySet::from_source(SourceSet::Population(
callback(EntitySet::from_source(SourceSet::full_population(
self.get_entity_count::<E>(),
)));
return;
Expand Down
Loading
Loading