chore: add clone support for entityset#837
Merged
RobertJacobsonCDC merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
Closed
Benchmark ResultsHyperfine
CriterionRegressions (slower)
Improvements (faster)
Unchanged / inconclusive (CI crosses 0%)
|
Collaborator
|
Let's rebase this one after we merge #826. |
RobertJacobsonCDC
approved these changes
Apr 7, 2026
Collaborator
RobertJacobsonCDC
left a comment
There was a problem hiding this comment.
Looks good! And useful!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
EntitySet<'a, E>cloneable by deep-cloning its lazy expression tree and adding clone support for property-backed source leaves.Changes
CloneforEntitySetandEntitySetInnerclone_box()toAbstractPropertySourcefor cloning boxed property sourcesCloneforConcretePropertySourceandDerivedPropertySourceCloneforSourceSet, includingPropertySet