63 update template response#64
Open
jsjiang wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the root (/) template rendering to match the newer Jinja2Templates.TemplateResponse call signature used by the current FastAPI/Starlette versions, and adds a basic regression test to ensure the HTML template response works.
Changes:
- Update
TemplateResponseinvocation to the newer keyword-based signature (request=..., name=...). - Add
test_root_template_responseto validateGET /returns HTML and HTTP 200. - Bump project version to
0.11.5and updateuv.lockaccordingly.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
rslv/app.py |
Updates the TemplateResponse call to the newer FastAPI/Starlette templating signature. |
tests/test_service.py |
Adds a regression test asserting / returns an HTML response successfully. |
pyproject.toml |
Bumps project version to 0.11.5. |
uv.lock |
Updates lockfile to reflect the new version and regenerated wheel entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sfisher
approved these changes
Jun 25, 2026
sfisher
left a comment
There was a problem hiding this comment.
This seems good to me. Thanks for adding the test and fixing this.
I don't know this service well, but was able to update with uv and run tests successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@datadavev @sfisher
This is to update TemplateResponse to use newer version signature and syntax introduced by FastAPI/Starlette upgrade. Resolver is on FastAPI v0.138.0 and Starlette 1.3.1 now.
From Fastapi:
A test case
test_root_template_responseis added with basic functional tests. This test triggered templateResponse related TypeError: unhashable type: 'dict' with current code.Please review and let me now if you have questions.
Thank you
Jing