Permissions: create separate Archiver read all, notification roles#698
Merged
zzacharo merged 1 commit intoCERNDocumentServer:masterfrom Feb 12, 2026
Merged
Conversation
8cbdbde to
44ab973
Compare
zzacharo
reviewed
Feb 12, 2026
site/cds_rdm/generators.py
Outdated
|
|
||
|
|
||
| class Archiver(Generator): | ||
| class ArchiverReader(Generator): |
Contributor
There was a problem hiding this comment.
Suggested change
| class ArchiverReader(Generator): | |
| class ArchiverRole(Generator): | |
| @property | |
| def archiver_role(): | |
| raise NotImplementedError() | |
| def needs(self, **kwargs): | |
| """Enabling Needs.""" | |
| return [self.archive_role] | |
| def query_filter(self, identity=None, **kwargs): | |
| """Filters for current identity as system process.""" | |
| for need in identity.provides: | |
| if need == self.archiver_role: | |
| return dsl.Q("match_all") | |
| else: | |
| return [] | |
| ... |
site/cds_rdm/generators.py
Outdated
|
|
||
| class Librarian(Generator): | ||
| """Allows librarian role.""" | ||
| class ArchiverNotification(Generator): |
Contributor
There was a problem hiding this comment.
Suggested change
| class ArchiverNotification(Generator): | |
| class ArchiverNotification(ArchiverRole): | |
| @property | |
| def archiver_role(): | |
| return archiver_notification_role |
44ab973 to
0350547
Compare
zzacharo
approved these changes
Feb 12, 2026
a6057ef to
218b9ec
Compare
218b9ec to
430c396
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is that the Preserve Platform dev and QA instance can use the Notification role and only for production it will obtain an API key with read all permission.