Add Float 2d snap rounding by LeoValque · Pull Request #8797 · CGAL/cgal

LeoValque · 2025-03-24T07:49:24Z

Summary of Changes

Add two functions that given a range of segments, rounds their coordinates to double while preserving the topology "up to collapse".

These functions differ from the actual snap rounding by rounding on double or any irregular grid instead of integer or any regular grid.

/// outputs a range of polylines, each polyline corresponding to snapped version of an input segment.
OutputContainer::iterator double_snap_rounding_2(InputIterator begin, InputIterator end,                                                  OutputContainer&)

/// outputs all the segments resulting from the snap rounding of the input.
`OutputContainer::iterator compute_snapped_subcurves_2(InputIterator begin, InputIterator end,                                                  OutputContainer&)

Release Management

Affected package(s): Snap rounding 2 ***
Feature/Small Feature (if any): Float_2D_Snap_rounding
Link to compiled documentation (obligatory for small feature):
License and copyright ownership: GF

Snap_rounding_2/include/CGAL/Float_snap_rounding_2.h

Snap_rounding_2/include/CGAL/vertical_slab_snap_rounding_2.h

Snap_rounding_2/include/CGAL/Float_snap_rounding_2.h

sloriot · 2025-04-01T19:38:21Z

Also, I think the user will be interested in having a correspondence between input and output segments

Snap_rounding_2/include/CGAL/Float_snap_rounding_2.h

afabri · 2025-06-30T15:07:44Z

What is the status of this pull request ?

albert-github · 2025-11-06T14:06:19Z

Looks like there are still errors in the documentation.
From https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.2-Ic-35/logs_master/Snap_rounding_2.log:

/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-35/doc/Snap_rounding_2/Concepts/FloatSnapRoundingTraits_2.h:7: warning: unable to resolve reference to 'CGAL::snap_rounding_' for \ref command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-35/doc/Snap_rounding_2/Concepts/FloatSnapRoundingTraits_2.h:149: warning: unable to resolve link to 'FloatSnapRoundingTraits_2::ConstructRoundPoint_2' for \link command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-35/doc/Snap_rounding_2/Concepts/FloatSnapRoundingTraits_2.h:166: warning: unable to resolve link to 'FloatSnapRoundingTraits_2::SquaredRoundBound_2' for \link command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-35/doc/Snap_rounding_2/Concepts/FloatSnapRoundingTraits_2.h:183: warning: unable to resolve link to 'FloatSnapRoundingTraits_2::ConverterToExact' for \link command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-35/doc/Snap_rounding_2/Concepts/FloatSnapRoundingTraits_2.h:202: warning: unable to resolve link to 'FloatSnapRoundingTraits_2::ConverterToExact' for \link command

Maybe: FloatSnapRoundingTraits_2 -> FSRTraits_2

albert-github · 2025-11-06T14:18:25Z

From https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.2-Ic-35/logs_master/Box_intersection_d.log (though file is changed in this PR):

/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-35/doc/Box_intersection_d/Box_intersection_d.txt:174: warning: unable to resolve reference to 'Box_intersection_d/boxes_with_different_types.cpp' for \ref command

Probably something with the EXAMPLE_PATH settings

afabri · 2025-11-12T08:36:09Z

Failure in the VC2017 testsuite CGAL-6.2-Ic-39

Snap_rounding_2/test/Snap_rounding_2/test_vertical_slab_snap_rounding.cpp

…ings

Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>

…irements

…ameter output_unique_segments to get polylines of length 2 without duplicates

github-actions · 2026-04-08T16:36:31Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8797/v4/Manual/index.html

Snap_rounding_2/doc/Snap_rounding_2/Snap_rounding_2.txt

Snap_rounding_2/include/CGAL/Hot_pixel_snap_rounding_traits_2.h

Snap_rounding_2/include/CGAL/Snap_rounding_2.h

Snap_rounding_2/include/CGAL/hot_pixel_snap_rounding_2.h

Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>

LeoValque · 2026-04-09T15:47:25Z

/force-build:v4

github-actions · 2026-04-09T15:50:15Z

There was an error while building the doc:

/home/runner/work/cgal/cgal/build_doc/doc_tags/Snap_rounding_2.tag:1700: warning: Duplicate anchor snap_rounding_2_fct found

https://github.com/CGAL/cgal/actions/runs/24199510293

LeoValque · 2026-04-09T16:12:54Z

/force-build:v4

github-actions · 2026-04-09T16:33:53Z

There was an error while building the doc:

/home/runner/work/cgal/cgal/build_doc/doc_tags/Snap_rounding_2.tag:1700: warning: Duplicate anchor snap_rounding_2_fct found

https://github.com/CGAL/cgal/actions/runs/24200716043

MaelRL added Enhancement Pkg::Snap_rounding_2 labels Mar 24, 2025

MaelRL added this to the 6.2-beta milestone Mar 24, 2025

sloriot requested changes Apr 1, 2025

View reviewed changes

afabri reviewed Apr 7, 2025

View reviewed changes

Snap_rounding_2/include/CGAL/Float_snap_rounding_2.h Show resolved Hide resolved

sloriot changed the base branch from master to main September 18, 2025 15:19

sloriot added Under Testing and removed Under Testing labels Oct 20, 2025

MaelRL added Not yet approved The feature or pull-request has not yet been approved. Small feature labels Oct 30, 2025

This comment was marked as outdated.

Sign in to view

sloriot added the Under Testing label Nov 5, 2025

This comment was marked as outdated.

Sign in to view

afabri reviewed Nov 20, 2025

View reviewed changes

Snap_rounding_2/test/Snap_rounding_2/test_vertical_slab_snap_rounding.cpp Show resolved Hide resolved

afabri reviewed Nov 20, 2025

View reviewed changes

Snap_rounding_2/test/Snap_rounding_2/test_vertical_slab_snap_rounding.cpp Show resolved Hide resolved

LeoValque mentioned this pull request Nov 24, 2025

Do curves intersect does not work with EPICK #9151

Open

Creation of float_snap_rounding_2.h and its example .cpp

173ae7b

LeoValque and others added 4 commits April 1, 2026 18:32

Delete the old examples of snap_rounding

dad7489

Remove deprecated declaration of Snap_rounding_traits_2 to avoid warn…

7f615dd

…ings

Apply suggestions from code review

34b921b

Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>

Apply suggestions from the review

8adab99

MaelRL mentioned this pull request Apr 2, 2026

Prepare CHANGES.md for 6.2 #9411

Open

8 tasks

Precise requirements on OutputIterator and add test with minimal requ…

4df7b0b

…irements

This comment was marked as outdated.

Sign in to view

LeoValque added 2 commits April 3, 2026 09:38

Fixing the snap rounding demo

35e32c0

fix dandling warning in the testsuite

02fa9d1

MaelRL modified the milestones: 6.2-beta, 6.3-beta Apr 7, 2026

sloriot removed the Under Testing label Apr 7, 2026

LeoValque added 2 commits April 8, 2026 13:08

Rewrite so that snap_rounding_2 outputs polylines and add a named par…

15dafbb

…ameter output_unique_segments to get polylines of length 2 without duplicates

Solve merge with main

7552e12

This comment was marked as outdated.

Sign in to view

MaelRL reviewed Apr 9, 2026

View reviewed changes

LeoValque and others added 3 commits April 9, 2026 14:21

Apply suggestions from code review

3471dc6

Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>

Apply suggestions from the review

54f830e

Apply remaining suggestions from the review

5a51b56

sloriot added the Under Testing label Apr 9, 2026

LeoValque added 2 commits April 9, 2026 18:06

Solve error in the demo

c963fed

Merge remote-tracking branch 'origin/main' into Float_2D_snap-GF

e238be9

Missing changement in the doc

836292a

Remove warnings of the testsuite

c2cbf14

Conversation

LeoValque commented Mar 24, 2025 • edited by MaelRL Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Release Management

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sloriot commented Apr 1, 2025

Uh oh!

Uh oh!

afabri commented Jun 30, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

albert-github commented Nov 6, 2025

Uh oh!

albert-github commented Nov 6, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

afabri commented Nov 12, 2025

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Apr 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LeoValque commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

LeoValque commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

LeoValque commented Mar 24, 2025 •

edited by MaelRL

Loading