Kinetic space partition: Reimplemented propagation#9396
Open
Kinetic space partition: Reimplemented propagation#9396
Conversation
fixed propagation input shapes from octree are now added using Intersection_kernel
afabri
requested changes
Mar 23, 2026
Kinetic_space_partition/include/CGAL/KSP_3/Intersection_graph.h
Outdated
Show resolved
Hide resolved
| std::set<std::size_t> crossed_lines; | ||
|
|
||
| std::vector<IEdge> iedges; | ||
| //std::vector<IEdge> iedges; |
Member
There was a problem hiding this comment.
Suggested change
| //std::vector<IEdge> iedges; |
Member
There was a problem hiding this comment.
There are more commented lines in this PR.
|
|
||
| m_data->centroid = CGAL::centroid(tris.begin(), tris.end(), CGAL::Dimension_tag<2>()); | ||
| m_data->ikcentroid = CGAL::centroid(points.begin(), points.end(), CGAL::Dimension_tag<0>()); |
Member
There was a problem hiding this comment.
Does the package have a traits class? Can we just use centroid() ?
Kinetic_space_partition/include/CGAL/KSP_3/Vertex_propagation.h
Outdated
Show resolved
Hide resolved
| { } | ||
| {} | ||
|
|
||
| Initializer(std::vector<std::vector<IkPoint_3> >& input_polygons, std::vector<typename Intersection_kernel::Plane_3>& input_planes, Data_structure& data, const Parameters& parameters) : |
Member
There was a problem hiding this comment.
The ":" of the initializer list should go in a new line.
added import for detected shapes and linear cell complex into KSR
Member
Author
|
/build:v0 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9396/v0/Manual/index.html |
added export functions used be the lcc streaming operator fixed splitting methods of Kinetic_surface_reconstruction_3 fixed Kinetic Surface Reconstruction Lab plugin completed D2 event in vertex propagation
[skip CI]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Added the vertex based propagation like it is implemented in the Inria version. Resulting in less complex partitions. However, the k-parameter is now per vertex and not per polygon. Meaning, increasing the k parameter has a larger impact than before.
Release Management