Add the CHERITech demo and fixes necessary for it to work#20
Open
davidchisnall wants to merge 8 commits intomainfrom
Open
Add the CHERITech demo and fixes necessary for it to work#20davidchisnall wants to merge 8 commits intomainfrom
davidchisnall wants to merge 8 commits intomainfrom
Conversation
demos/2024-04-23-cheritech/demo.cc
Outdated
| char clientID[clientIDlength] = "cheriot-XXXXXXXXXXXXXX"; | ||
|
|
||
| /** | ||
| * Turn an LED on. |
There was a problem hiding this comment.
Should this comment be different from the one for led_on?
Contributor
Author
There was a problem hiding this comment.
You seem to be reviewing something that was removed in a later commit.
There was a problem hiding this comment.
I assume you copied the files in this commit from somewhere. If so, can you point to the originals if they are in another open repo?
Contributor
Author
There was a problem hiding this comment.
They are 'copied' from my Morello machine. I'm not sure what this is asking for.
davidchisnall
force-pushed
the
demo-wip
branch
2 times, most recently
from
e49e28c to
419af6b
Compare
For larger buffers, this does not fit in the maximum size of sealed objects.
JavaScript VM is linked but not yet used. 16 KiB free.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.