DNS resolver: fix incorrect management of state.#79
Merged
davidchisnall merged 1 commit intoCHERIoT-Platform:mainfrom Feb 3, 2026
Merged
DNS resolver: fix incorrect management of state.#79davidchisnall merged 1 commit intoCHERIoT-Platform:mainfrom
davidchisnall merged 1 commit intoCHERIoT-Platform:mainfrom
Conversation
rmn30
commented
Jan 31, 2026
|
|
||
| SystickReturn timestampAfter = thread_systemtick_get(); | ||
| // Timeouts should not overflow a 32 bit value | ||
| timeout->elapse(timestampAfter.lo - timestampBefore.lo); |
Contributor
Author
There was a problem hiding this comment.
I think this double counts the time spent in state.wait above. Is it really necessary to manually elapse the timeout here?
1) the state needs to be reset to ready after failures. 2) incorrect use of futex.wait in loop on entry to network_host_resolve: we need to wait on the previous value changing, not the value we want. 3) make sure to notify on changes to state (err on side of caution).
rmn30
force-pushed
the
rmn30/dns_state
branch
from
9eb8f51 to
a5a0dde
Compare
davidchisnall
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still not totally confident about this.