DNS: fix error in checking query ID#82
Merged
davidchisnall merged 1 commit intoCHERIoT-Platform:mainfrom Feb 5, 2026
Merged
Conversation
This check of DNS query ID was totally wrong as it: 1) was checking for equality instead of inequality 2) was unnecessarily byte swapping the queryID These two errors combined so that responses were accepted providing the byte swapped queryID did not match the expected queryID. This meant most responses were accepted unless the query ID had two equal bytes, which occassionally happened by chance and caused the query to time out until the next query chose a different queryID.
Contributor
Author
|
@hlef might find this amusing |
davidchisnall
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check of DNS query ID was totally wrong as it:
These two errors combined so that responses were accepted providing the byte swapped queryID did not match the expected queryID. This meant most responses were accepted unless the query ID had two equal bytes, which occassionally happened by chance and caused the query to time out until the next query chose a different queryID.