Conversation
❌ Deploy Preview for wonderful-blackwell-a043b5 failed.
|
| "url": "http://localhost:8080", | ||
| "url": "http://localhost:8081", | ||
| "webRoot": "${workspaceFolder}/src", | ||
| "tmpDir": "/home/ericx/Desktop/FirefoxTemp", |
There was a problem hiding this comment.
Use relative path directories to ensure that paths don't get broken
| "cSpell.words": ["registryref"], | ||
| "editor.codeActionsOnSave": { | ||
| "source.fixAll.eslint": true | ||
| "source.fixAll.eslint": "explicit" |
There was a problem hiding this comment.
Why did you change this ?
There was a problem hiding this comment.
Is this a duplicate file ?
| @@ -1,3 +1,11 @@ | |||
| (function() { | |||
There was a problem hiding this comment.
What are you using this for ?
| "x-span": bounds.width, | ||
| "y-span": bounds.height, |
There was a problem hiding this comment.
An you verify whether _xspan and _yspan are not retrieving the right values. If thats the case please create getters for those two properties to return the width and height of the bounds
| console.log(render); | ||
| console.log(featureid); | ||
| console.log(render.bounds); |
There was a problem hiding this comment.
Unnecessary logging, please remove
|
|
||
| /** | ||
| * Gets the mirrorByX of the component | ||
| * @returns {Number} Returns the degree of rotation |
There was a problem hiding this comment.
Is it returning degrees of rotation ?
| addComponent(component: Component): void { | ||
| if (component instanceof Component) { | ||
| this.__components.push(component); | ||
| console.log("component",component) |
| deriveRenderName(): string { | ||
| if (!ComponentAPI.library[this.type]) { | ||
| console.error("Type unrecognized, defaulting to template."); | ||
| this._type = "Template"; |
There was a problem hiding this comment.
Any particular reason for removing this ? I'm more curious than anything else
There was a problem hiding this comment.
What are you using this for ?
| //Commented out due to additional parameter added to method | ||
| // const render = ComponentPortRenderer2D.renderComponentPort(componentport, [0,0], 0, 0, 0, zfactor); | ||
| // componentportrenders.push(render); |
There was a problem hiding this comment.
So we are not rendering the component ports now ?
rkrishnasanka
left a comment
rkrishnasanka
left a comment
There was a problem hiding this comment.
Looks good overall, however some small modifications need to change. Especially if x and y span properties are not returning the right values, we need to make sure that they working correctly (since this is being used in more places other than export).
2 participants
No description provided.